Skip to content

Improper equals override is fixed to prevent NullPointerException#6938

Merged
clintropolis merged 3 commits intoapache:masterfrom
kamaci:feature/tasklockbox-equals
Feb 6, 2019
Merged

Improper equals override is fixed to prevent NullPointerException#6938
clintropolis merged 3 commits intoapache:masterfrom
kamaci:feature/tasklockbox-equals

Conversation

@kamaci
Copy link
Copy Markdown
Member

@kamaci kamaci commented Jan 29, 2019

No description provided.

@jihoonson jihoonson added the Bug label Jan 29, 2019
@jihoonson
Copy link
Copy Markdown
Contributor

Would you please add a unit test?

@egor-ryashin
Copy link
Copy Markdown
Contributor

LGTM

@kamaci
Copy link
Copy Markdown
Member Author

kamaci commented Jan 31, 2019

Sure 👍

@jon-wei jon-wei added this to the 0.14.0 milestone Feb 1, 2019
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@clintropolis clintropolis merged commit 58f9507 into apache:master Feb 6, 2019
clintropolis pushed a commit to clintropolis/druid that referenced this pull request Feb 6, 2019
…ache#6938)

* Improper equals override is fixed to prevent NullPointerException

* Fixed curly brace indentation.

* Test method is added for equals method of TaskLockPosse class.
fjy pushed a commit that referenced this pull request Feb 7, 2019
) (#7022)

* Improper equals override is fixed to prevent NullPointerException

* Fixed curly brace indentation.

* Test method is added for equals method of TaskLockPosse class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants