fix kafka index task doesn't resume when recieve duplicate request#6990
fix kafka index task doesn't resume when recieve duplicate request#6990clintropolis merged 2 commits intoapache:masterfrom
Conversation
clintropolis
left a comment
There was a problem hiding this comment.
I think I see what's going on here and that this makes sense, 👍
Is it a major hassle to add a test for this?
|
Hi @QiuMM, would you elaborate more on this case? When and how can it happen that a kafka task is paused for the same endOffsets twice or more? |
|
@jihoonson I am not sure how it happen, I just observed one kafka index task pasuing forever and found log like this: |
|
@QiuMM thanks. I guess it might happen if no data has been ingested since the first endOffsets update when the second pause & update endOffsets are requested. I just wanted to check that my guess is correct. The latest change looks good to me. |
clintropolis
left a comment
There was a problem hiding this comment.
Thanks for adding a test, LGTM 👍
…pache#6990) * fix kafka index task doesn't resume when recieve duplicate request * add unit test
When the kafka index task recieve duplicate
setEndOffsetsrequest, it returns and doesn't callresume(), this will cause the task pausing forever.