Fix for getSingleObjectSummary, replacing keyCount with objectSummaries().size#7000
Merged
clintropolis merged 3 commits intoapache:masterfrom Feb 5, 2019
Merged
Conversation
Contributor
Author
|
@jihoonson I don't have write access to this repository so I can't merge this PR, can you please merge it? or let me know if there is any other process for it? |
Contributor
|
@anantmf we usually keep a PR open for a while even after it gets a +1 to give some time for other people to take a look it too. I'll merge this PR maybe tonight unless anyone has another opinion. |
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Feb 6, 2019
…es().size (apache#7000) * Instead of using keyCount, changing it to check the size of objectSummaries. For issue: apache#6980 apache#6980 (comment) * Changing another usage of keyCount with size of objectSummaries. * Adding some comments to explain why using keyCount is not working as expected.
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Feb 6, 2019
…es().size (apache#7000) * Instead of using keyCount, changing it to check the size of objectSummaries. For issue: apache#6980 apache#6980 (comment) * Changing another usage of keyCount with size of objectSummaries. * Adding some comments to explain why using keyCount is not working as expected.
fjy
pushed a commit
that referenced
this pull request
Feb 7, 2019
…es().size (#7000) (#7013) * Instead of using keyCount, changing it to check the size of objectSummaries. For issue: #6980 #6980 (comment) * Changing another usage of keyCount with size of objectSummaries. * Adding some comments to explain why using keyCount is not working as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using keyCount, changing it to check the size of objectSummaries.
For issue:
#6980
#6980 (comment)