Skip to content

Missing Overlord and MiddleManager api docs#7042

Merged
jihoonson merged 8 commits intoapache:masterfrom
clintropolis:middle-manager-api-docs
Feb 19, 2019
Merged

Missing Overlord and MiddleManager api docs#7042
jihoonson merged 8 commits intoapache:masterfrom
clintropolis:middle-manager-api-docs

Conversation

@clintropolis
Copy link
Copy Markdown
Member

@clintropolis clintropolis commented Feb 8, 2019

Adds missing Overlord and MiddleManager API documentation, fixes #5917

Check whether a MiddleManager is in an enabled or disabled state. Returns JSON object keyed by the `druid.host` and the boolean state.

```json
{"localhost":true}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure it returns host:port.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes you are correct, thanks for catching! 👍

@clintropolis
Copy link
Copy Markdown
Member Author

clintropolis commented Feb 13, 2019

Now with more missing Overlord API documentation as well.

@clintropolis clintropolis changed the title MiddleManager api docs Missing Overlord and MiddleManager api docs Feb 13, 2019
@jon-wei jon-wei added this to the 0.14.0 milestone Feb 13, 2019
@clintropolis clintropolis removed the WIP label Feb 13, 2019
Copy link
Copy Markdown

@surekhasaharan surekhasaharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintropolis for adding docs and cleaning up some of the unused code. Took a 1st pass, left some minor comments.

| `datasource`| return tasks filtered by Druid datasource.|
| `createdTimeInterval`| return tasks created within the specified interval. |
| `max`| maximum number of `"complete"` tasks to return. Only applies when `state` is set to `"complete"`.|
| `type`| filter tasks by task type.|
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should add what are some of the types, say, "where type can be index, kill, compact etc." or if we want to put all the types from here, in addition there are index_kafka and index_kinesis, I think. If you feel the list is long, I'm fine with just few examples.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are too many, and it can't really be done exhaustively since extensions can add to this as well. Instead I think I'm going to link to ingestion tasks doc to at least point users in the right direction.


* `/druid/indexer/v1/runningTasks`

Retrieve list of complete tasks. Equivalent to `/druid/indexer/v1/tasks?state=running`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it should be "Retrieve list of running tasks".


* `/druid/indexer/v1/waitingTasks`

Retrieve list of complete tasks. Equivalent to `/druid/indexer/v1/tasks?state=waiting`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, and at few other places below

Copy link
Copy Markdown
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.


##### DELETE

* `/druid/indexer/v1/pendingSegments/{dataSource}`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this was intended for internal use only. Do you think it would be useful for people too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i wasn't thinking so hard about it. I think it's harmless to leave, but linked to druid.coordinator.kill.pendingSegments.on to mention that it can be done automatically via config.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 👍

@jihoonson jihoonson merged commit cadb6c5 into apache:master Feb 19, 2019
clintropolis added a commit to clintropolis/druid that referenced this pull request Feb 20, 2019
* document middle manager api

* re-arrange

* correction

* document more missing overlord api calls, minor re-arrange of some code i was referencing

* fix it

* this will fix it

* fixup

* link to other docs
fjy pushed a commit that referenced this pull request Feb 20, 2019
* document middle manager api

* re-arrange

* correction

* document more missing overlord api calls, minor re-arrange of some code i was referencing

* fix it

* this will fix it

* fixup

* link to other docs
@clintropolis clintropolis deleted the middle-manager-api-docs branch March 6, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document missing Overlord APIs

5 participants