Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2127,6 +2127,49 @@ public void testRunContextSequenceAheadOfStartingOffsets() throws Exception
Assert.assertEquals(ImmutableList.of("d", "e"), readSegmentColumn("dim1", desc2));
}

@Test(timeout = 60_000L)
public void testRunWithDuplicateRequest() throws Exception
{
// Insert data
try (final KafkaProducer<byte[], byte[]> kafkaProducer = kafkaServer.newProducer()) {
for (ProducerRecord<byte[], byte[]> record : records) {
kafkaProducer.send(record).get();
}
}

final KafkaIndexTask task = createTask(
null,
new KafkaIndexTaskIOConfig(
0,
"sequence0",
new SeekableStreamPartitions<>(topic, ImmutableMap.of(0, 200L)),
new SeekableStreamPartitions<>(topic, ImmutableMap.of(0, 500L)),
kafkaServer.consumerProperties(),
KafkaSupervisorIOConfig.DEFAULT_POLL_TIMEOUT_MILLIS,
true,
null,
null,
false
)
);

runTask(task);

while (!task.getRunner().getStatus().equals(Status.READING)) {
Thread.sleep(20);
}

// first setEndOffsets request
task.getRunner().pause();
task.getRunner().setEndOffsets(ImmutableMap.of(0, 500L), true);
Assert.assertEquals(Status.READING, task.getRunner().getStatus());

// duplicate setEndOffsets request
task.getRunner().pause();
task.getRunner().setEndOffsets(ImmutableMap.of(0, 500L), true);
Assert.assertEquals(Status.READING, task.getRunner().getStatus());
}

private ListenableFuture<TaskStatus> runTask(final Task task)
{
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1403,6 +1403,7 @@ public Response setEndOffsets(
exclusivePartitions) && !finish) ||
(latestSequence.getEndOffsets().equals(sequenceNumbers) && finish)) {
log.warn("Ignoring duplicate request, end sequences already set for sequences [%s]", sequenceNumbers);
resume();
return Response.ok(sequenceNumbers).build();
} else if (latestSequence.isCheckpointed()) {
return Response.status(Response.Status.BAD_REQUEST)
Expand Down