Skip to content

Fix momentsketch build issues#7074

Merged
jon-wei merged 5 commits intoapache:masterfrom
jon-wei:moment_sketch_fix
Feb 14, 2019
Merged

Fix momentsketch build issues#7074
jon-wei merged 5 commits intoapache:masterfrom
jon-wei:moment_sketch_fix

Conversation

@jon-wei
Copy link
Copy Markdown
Contributor

@jon-wei jon-wei commented Feb 13, 2019

The CI checks in #6581 were stale (they finished before some incompatible changes in master were merged), this PR fixes the build issues.

@jon-wei jon-wei added the Bug label Feb 13, 2019
Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jihoonson
Copy link
Copy Markdown
Contributor

+1 after CI.

@jon-wei jon-wei merged commit 1f29940 into apache:master Feb 14, 2019
complexSerializers.put(type, serde);
}

public static void registerSerde(String type, Supplier<ComplexMetricSerde> serdeSupplier)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jon-wei this method was added on purpose to be used in other modules. See #7058.

@jihoonson jihoonson added this to the 0.15.0 milestone May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants