ITIndexerTest: validate new data source after reindex#7171
Merged
jihoonson merged 1 commit intoapache:masterfrom Mar 4, 2019
apollographql:glasser/itindexertest-validate
Merged
ITIndexerTest: validate new data source after reindex#7171jihoonson merged 1 commit intoapache:masterfrom apollographql:glasser/itindexertest-validate
jihoonson merged 1 commit intoapache:masterfrom
apollographql:glasser/itindexertest-validate
Conversation
Previously, the test validated that the data source that we ingested from still had the same query responses that it did before the second ingestion. This is less useful than validating queries against the newly created data source. The new queries file differs from the old one in that its maxTime is earlier due to the interval selected by the reindex, and in that it does not query for the dropped metric "count".
Contributor
Author
|
(The errors highlighted by TeamCity do not appear to be in files touched by this PR.) |
jihoonson
reviewed
Mar 4, 2019
| @@ -0,0 +1,66 @@ | |||
| [ | |||
Contributor
There was a problem hiding this comment.
I guess we don't need this new query? It's same with wikipedia_index_queries.json except that rows is missing in this query.
Contributor
Author
There was a problem hiding this comment.
The differences are:
- maxTime in the first query is different (because the second ingest pulls a subset of time)
- not asking for the now-gone
countmetric in the second query (is that what you mean byrows?)
Are you proposing just not doing queries at all after the reingest? It seems reasonable to validate that some data ended up in the new datasource.
Contributor
There was a problem hiding this comment.
Oh I see. I missed the 1st change. It looks good to me. Thanks.
jihoonson
approved these changes
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the test validated that the data source that we ingested from still
had the same query responses that it did before the second ingestion. This is
less useful than validating queries against the newly created data source.
The new queries file differs from the old one in that its maxTime is earlier due
to the interval selected by the reindex, and in that it does not query for the
dropped metric "count".