support sin cos etc trigonometric function in sql#7182
Merged
gianm merged 2 commits intoapache:masterfrom Mar 5, 2019
Merged
Conversation
gianm
reviewed
Mar 4, 2019
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
@xueyumusic, could you please test this patch against the latest master (it uses EXPRESSION_POST_AGG, which has been renamed recently) and also add docs to math-expr.md and sql.md for the new functions?
Other than those things and the line comments, this looks good to me.
Contributor
There was a problem hiding this comment.
Could be extracted to a private static final constant.
Contributor
There was a problem hiding this comment.
You might need to put one result on each line to satisfy the style checker.
xueyumusic
force-pushed
the
triangle-func
branch
from
494e4a6 to
08db94d
Compare
Contributor
Author
|
Hi, @gianm , Thanks a lot for review. I have rebased on master and updated the codes, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to support sin, cos, tan, cot, asin, acos, atan, atan2 etc function and pi constant in sql based on the current calcite framework. They are common math functions.