integration-tests: make ITParallelIndexTest still work in parallel#7211
integration-tests: make ITParallelIndexTest still work in parallel#7211gianm merged 2 commits intoapache:masterfrom apollographql:glasser/it-parallel-stay-parallel
Conversation
|
+1 after CI. Thank you @glasser! |
|
Though I wonder if the tests should check that the expected number of sub tasks were created. |
|
Also I should put the field on the right object. |
|
@glasser oops. Thank you for checking the spec again. I think checking number of created tasks should be covered by unit tests. |
|
Maybe it’s not covered yet. If so, we may need to improve ParallelIndexSupervisorResourceTest to cover it. |
Follow-up to #7181, which made the default behavior for index_parallel tasks non-parallel.
|
OK, this is passing for me now. The first commit just adds the missing task spec lines as requested. The second commit validates that at least one sub task got run per indexing run. If you don't think that's necessary, feel free to drop it from the branch before merging, but it seems nice to validate the issue this PR is fixing. |
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
Ok. The second commit sounds good to me.
There was a problem hiding this comment.
The error message should be more detailed. How about The supervisor task[taskId] didn't create any sub tasks. Was it executed in the parallel mode?
|
@jihoonson done. (and moved it into a different function, which makes it accessible to |
|
CI passed. |
3 participants
Follow-up to #7181, which made the default behavior for index_parallel tasks
non-parallel.