Skip to content

google-extensions: upgrade google-http-client, fix "logs (last 8kb)"#7218

Closed
glasser wants to merge 1 commit intoapache:masterfrom
apollographql:glasser/logs-last-8kb
Closed

google-extensions: upgrade google-http-client, fix "logs (last 8kb)"#7218
glasser wants to merge 1 commit intoapache:masterfrom
apollographql:glasser/logs-last-8kb

Conversation

@glasser
Copy link
Copy Markdown
Contributor

@glasser glasser commented Mar 8, 2019

This upgrade gets us the fix to
googleapis/google-http-java-client#447 which fixes the
"logs (last 8kb)" link for completed tasks on the Overlord console.

It is the minimum possible upgrade to get the fix. Going all the way to
present (1.28.0) has breaking changes; see
https://github.com/googleapis/google-http-java-client/releases

Fixes #7076.

This upgrade gets us the fix to
googleapis/google-http-java-client#447 which fixes the
"logs (last 8kb)" link for completed tasks on the Overlord console.

It is the minimum possible upgrade to get the fix. Going all the way to
present (1.28.0) has breaking changes; see
https://github.com/googleapis/google-http-java-client/releases

Fixes #7076.
@drcrallen drcrallen mentioned this pull request Mar 18, 2019
5 tasks
@stale
Copy link
Copy Markdown

stale Bot commented May 11, 2019

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label May 11, 2019
@glasser
Copy link
Copy Markdown
Contributor Author

glasser commented May 11, 2019

It looks like #6953 by @drcrallen moved around the number affected by this. The version number is now com.google.apis.client.version in the top-level pom.xml, which is used for more than just the http client library.

I'm on parental leave right now so I'm not in a great place to update this PR.

@stale stale Bot removed the stale label May 11, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Jul 10, 2019

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Jul 10, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Jul 18, 2019

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale Bot closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCS task logs: "logs (last 8kb)" link is broken

1 participant