Fix ITRealtimeIndexTaskTest Flakiness#7232
Merged
fjy merged 2 commits intoapache:masterfrom Mar 12, 2019
Merged
Conversation
justinborromeo
changed the title
justinborromeo
changed the title
gianm
reviewed
Mar 12, 2019
| LOG.info("indexerSpec: [%s]\n", task); | ||
| taskID = indexer.submitTask(task); | ||
|
|
||
| TimeUnit.SECONDS.sleep(5); |
Contributor
There was a problem hiding this comment.
Could you please include a comment about why this is happening?
gianm
approved these changes
Mar 12, 2019
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
Better than it was, at least.
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
Mar 15, 2019
* Testing sleep change before posting events * Added comment
Member
|
I still see flakiness in this test: #8918, should we make the pause longer or rather implement deterministic wait? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7219 and fixes #7017. ITRealtimeIndexTaskTest has been borking Travis builds. Adding a 5-second pause before posting events seems to help. Maybe the test was trying to post events before the peons had fully started? With this change, the test has passed 5/5 times.