Fix testIncrementalHandOffReadsThroughEndOffsets in Kafka/KinesisIndexTaskTest#7264
Merged
gianm merged 5 commits intoapache:masterfrom Mar 15, 2019
Merged
Fix testIncrementalHandOffReadsThroughEndOffsets in Kafka/KinesisIndexTaskTest#7264gianm merged 5 commits intoapache:masterfrom
gianm merged 5 commits intoapache:masterfrom
Conversation
| // Simulating the case when another replica has consumed up to the offset of 8 | ||
| task.getRunner().setEndOffsets(ImmutableMap.of(0, 8L), false); | ||
| normalReplica.getRunner().setEndOffsets(currentOffsets, false); | ||
| staleReplica.getRunner().setEndOffsets(currentOffsets, false); |
Member
There was a problem hiding this comment.
Is it assumed that staleReplica has offsets behind normalReplica offsets? Is this testable?
Contributor
Author
There was a problem hiding this comment.
That is my intention, but this test doesn't guarantee that staleReplica is always behind normalReplica. My assumption here is that staleReplica would be stale in most runs.
| } else { | ||
| rows = new ArrayList<>(); | ||
| for (byte[] valueBytes : valueBytess) { | ||
| log.info("valueBytes len: " + valueBytes.length); |
Member
There was a problem hiding this comment.
Is this really an info level log?
Contributor
Author
There was a problem hiding this comment.
Oh, it was my debugging log. Will remove.
gianm
approved these changes
Mar 15, 2019
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
Mar 15, 2019
…xTaskTest (apache#7264) * Fix testIncrementalHandOffReadsThroughEndOffsets in Kafka/KinesisIndexTaskTest * revert unnecessary change * fix test * remove debug log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both tests are running with transactional mode, so offsets might not be consecutive. This PR runs two tasks to simulate stale replica.