Fix unrealistic test variables in KafkaSupervisorTest and tidy up unused variable in checkpointing process#7319
Merged
jihoonson merged 9 commits intoapache:masterfrom Aug 21, 2019
Conversation
jihoonson
changed the title
Contributor
|
@jihoonson mind fixing conflicts? |
Contributor
Author
|
@fjy sure fixed. |
| @Deprecated String baseSequenceName, | ||
| SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> previousCheckpoint, | ||
| SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> currentCheckpoint | ||
| SeekableStreamDataSourceMetadata<PartitionIdType, SequenceOffsetType> previousCheckpoint |
There was a problem hiding this comment.
should previousCheckpoint be renamed to checkpointMetadata ?
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
Contributor
Author
|
Will fix this. |
|
This issue is no longer marked as stale. |
…afka-supervisor-test
clintropolis
approved these changes
Aug 21, 2019
Contributor
Author
|
@fjy @clintropolis @surekhasaharan thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start sequence numbers would never have exclusivePartitions in Kafka. Having exclusivePartitions in unit tests wouldn't harm, but would never happen in production. Also, the second parameter for
checkpoint()is not being used. I removed it.Since this is not a bug fix, but just tidying up unused variables and test variables, it doesn't have to be backported.