Merged
Conversation
drcrallen
approved these changes
Mar 27, 2019
jihoonson
approved these changes
Mar 27, 2019
Contributor
|
@clintropolis thanks for the quick fix! It works in my local. Looks that Travis is not being started because of Slow booting linux builds issue in Travis. I would vote for merging this PR without waiting for Travis because it's blocking people from building master. |
justinborromeo
approved these changes
Mar 27, 2019
Contributor
@drcrallen what do you think? |
Member
Author
|
CI didn't really catch this before this patch, so I don't think it would change the outcome |
justinborromeo
pushed a commit
to justinborromeo/incubator-druid
that referenced
this pull request
Apr 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed
groupIdwhen extension got moved from contrib to core in #6953, fixes #7357