SQL explain in web console#7402
Merged
clintropolis merged 7 commits intoapache:masterfrom Apr 5, 2019
Merged
Conversation
Contributor
|
Why is the label centered and not left aligned in the menu? |
vogievetsky
reviewed
Apr 4, 2019
vogievetsky
requested changes
Apr 4, 2019
Contributor
vogievetsky
left a comment
vogievetsky
left a comment
There was a problem hiding this comment.
A bit of tidy up is needed
Contributor
|
@shuqi7 in the future please do not force push your branch after making the PR, it makes it harder to see what changes have been made when. |
vogievetsky
requested changes
Apr 4, 2019
Contributor
|
Looking good. Thank you for promptly addressing the feedback. 👍 |
clintropolis
approved these changes
Apr 5, 2019
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
Nice 👍
It does make me sad you have to parse the explain like that, maybe in the future we could give it back in a format that is a bit more friendly...
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 10, 2019
* Add explain for SQL query * Terminate explain query manager * Add signature for semi-joined queries * Extract components out * Hide more button in rune mode * Add types for query explanation parser * Add type for query-plan-dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7377
explain plan for queryand parse the response into JSON in a dialogThere are 4 different situations:
semi-joinedqueries