No SQL mode in web console#7493
Merged
clintropolis merged 14 commits intoapache:masterfrom Apr 23, 2019
Merged
Conversation
vogievetsky
requested changes
Apr 19, 2019
Contributor
vogievetsky
left a comment
vogievetsky
left a comment
There was a problem hiding this comment.
Can you tell that I am not a fan of reduce?
vogievetsky
reviewed
Apr 19, 2019
Contributor
|
Made a quick note on the wording of the notice and I think it is good otherwise. 👍 once my comment above is addressed. |
vogievetsky
reviewed
Apr 19, 2019
| let servers: ServerQueryResultRow[]; | ||
| if (!noSqlMode) { | ||
| servers = await queryDruidSql({ query }); | ||
| if (servers.length === 0) { |
Contributor
Contributor
Author
There was a problem hiding this comment.
Will implement another way of querying the servers in a separate PR
clintropolis
approved these changes
Apr 23, 2019
clintropolis
pushed a commit
to implydata/druid-public
that referenced
this pull request
May 2, 2019
* Added no sql mode * Use status code * Add no sql mode to server view * add sql broker check to decide if no sql mode should be enabled * Fix historicals in home view * Name change * Add types for query result; improved functions * Fixed a conflict/bug * Fixed a bug * multiple fix * removed unused imports * terminate query manager * fix wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.