Adds backwards-compatible serde for SeekableStreamStartSequenceNumbers.#7512
Merged
fjy merged 1 commit intoapache:masterfrom Apr 19, 2019
Merged
Adds backwards-compatible serde for SeekableStreamStartSequenceNumbers.#7512fjy merged 1 commit intoapache:masterfrom
fjy merged 1 commit intoapache:masterfrom
Conversation
This allows them to be deserialized by older Druid versions as KafkaPartitions objects. Fixes apache#7470.
gianm
changed the title
jihoonson
approved these changes
Apr 19, 2019
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. Tested by running a middleManager of this patch and an overlord of 0.13.0, and killing kafka tasks several times and checking new tasks start properly.
Contributor
Author
|
Thanks for the review & test @jihoonson! |
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Apr 20, 2019
…s. (apache#7512) This allows them to be deserialized by older Druid versions as KafkaPartitions objects. Fixes apache#7470.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows them to be deserialized by older Druid versions as
KafkaPartitions objects.
Fixes #7470.