Conversation
|
Could you add a test for this please? (It seems like the kind of thing that's likely to get missed if the code is ever refactored, so a test is good to protect against that.) |
|
Could you point me to the best example of a test for such a purpose? Should it be a micro-test (minimalistic unit test) or some sort of an integration test similar to what we do now in DoublesSketchAggregatorTest where we construct a json query and run it using the AggregationTestHelper? |
|
@AlexanderSaydakov I am not intimately familiar with the code, but I'd guess that a minimalistic unit test would be best. In general I prefer unit tests when feasible. |
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
LGTM after CI - thanks @AlexanderSaydakov!
|
I don't understand what happened with the inspection: |
|
TeamCity inspection report doesn't show any new errors in the files affected by this patch, merging |
* handle empty sketches * return array of NaN in case of empty sketch * noinspection ForLoopReplaceableByForEach in tests * style fixes
* handle empty sketches * return array of NaN in case of empty sketch * noinspection ForLoopReplaceableByForEach in tests * style fixes
4 participants
this is to address #7486