Skip to content

Fix old-console/cluster.html; Remove redundant throws in ITBasicAuthConfigurationTest#7589

Merged
leventov merged 2 commits intoapache:masterfrom
metamx:tc-intellij-2018-4
May 6, 2019
Merged

Fix old-console/cluster.html; Remove redundant throws in ITBasicAuthConfigurationTest#7589
leventov merged 2 commits intoapache:masterfrom
metamx:tc-intellij-2018-4

Conversation

@leventov
Copy link
Copy Markdown
Member

@leventov leventov commented May 3, 2019

Continue efforts to try to resolve problems that prevent TeamCity from updating to IntelliJ 2018.2 engine, started in #7499 and #7541.

Comment thread web-console/old-console/cluster.html Outdated
</form>
</div>
<!--<div id="drop">
<div id="drop">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you are only removing one side of the comment? I have no idea what this is about but should you also remove the --> on line 67?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is your fix that this comment is unbalanced?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's a comment inside another comment. Might as well just delete the whole thing, I suppose.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leventov could you delete the whole comment?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

Comment thread web-console/old-console/cluster.html Outdated
</form>
</div>
<!--<div id="drop">
<div id="drop">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leventov could you delete the whole comment?

@leventov leventov merged commit a00d3e1 into apache:master May 6, 2019
@leventov leventov deleted the tc-intellij-2018-4 branch May 6, 2019 16:08
@jihoonson jihoonson added this to the 0.15.0 milestone May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants