Add simpler permissions option to BasicAuthorizer GET APIs#7635
Merged
jon-wei merged 3 commits intoapache:masterfrom May 15, 2019
Merged
Add simpler permissions option to BasicAuthorizer GET APIs#7635jon-wei merged 3 commits intoapache:masterfrom
jon-wei merged 3 commits intoapache:masterfrom
Conversation
himanshug
approved these changes
May 14, 2019
Co-Authored-By: Himanshu <g.himanshu@gmail.com>
Co-Authored-By: Himanshu <g.himanshu@gmail.com>
jon-wei
added a commit
to implydata/druid-public
that referenced
this pull request
May 20, 2019
* Add simpler permissions option to BasicAuthorizer GET APIs * Adjust log message Co-Authored-By: Himanshu <g.himanshu@gmail.com> * Adjust log message Co-Authored-By: Himanshu <g.himanshu@gmail.com>
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 3, 2019
* Add simpler permissions option to BasicAuthorizer GET APIs * Adjust log message Co-Authored-By: Himanshu <g.himanshu@gmail.com> * Adjust log message Co-Authored-By: Himanshu <g.himanshu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
?simplifyPermissionsoption to the GET APIs for users and roles in thedruid-basic-securityauthorization APIs.The current output of these APIs can return a list of associated permissions. However, the output format of these permissions has an extra compiled regex field, and it does not match the input format for permissions used by the permissions update APIs. The compiled regex is redundant and is not useful for clients, it is stored internally to avoid recompiling the regex patterns.
This inconsistency complicates the use of these APIs for clients such as frontends for editing the authorization configuration, since they must deal with two different permissions formats.
Specifying
?simplifyPermissionswill return consistent output.This PR deprecates the old formats; in a later release the default output formats should be switched to match the output when
?simplifyPermissionsis used.