Web console: fixed issue when grouping tasks by different attributes#7657
Merged
clintropolis merged 2 commits intoapache:masterfrom May 16, 2019
Merged
Web console: fixed issue when grouping tasks by different attributes#7657clintropolis merged 2 commits intoapache:masterfrom
clintropolis merged 2 commits intoapache:masterfrom
Conversation
Merged
Contributor
|
This is not the correct approach to this issue it effectively undoes the tie-breaker reverting back to the state where the tasks are ordered incorrectly:
(see how the time within successful tasks is ascending, it should be descending) The correct approach is to define a This gives that object a canonical string value and tricks ReactTable to work as intended. |
Contributor
|
Looks good to me now. Could we change the PR title to something like |
jennyzzz
changed the title
Contributor
|
Awesome thank you! 👍 |
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
May 28, 2019
…pache#7657) * deleted created_time in "status" * added toString on the status object
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 26, 2019
…pache#7657) * deleted created_time in "status" * added toString on the status object
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 4, 2019
…pache#7657) * deleted created_time in "status" * added toString on the status object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for master, but is also included in "Data loader fixes #7672" (for 0.15.0).
Issue:
Expected:
Current UI after this fix:
it can be grouped by type:
Or grouped by status:
