allow quantiles merge aggregator to also accept doubles#7718
Merged
himanshug merged 3 commits intoapache:masterfrom May 23, 2019
Merged
allow quantiles merge aggregator to also accept doubles#7718himanshug merged 3 commits intoapache:masterfrom
himanshug merged 3 commits intoapache:masterfrom
Conversation
himanshug
approved these changes
May 21, 2019
| union.update((DoublesSketch) object); | ||
| } else { | ||
| union.update(selector.getDouble()); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: would be nice to extract last 5 lines in either of the aggregator classes.
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
May 23, 2019
* allow quantiles merge aggregator to also accept doubles * consolidate dupe * import
fjy
pushed a commit
that referenced
this pull request
May 24, 2019
clintropolis
added a commit
to implydata/druid-public
that referenced
this pull request
May 24, 2019
* allow quantiles merge aggregator to also accept doubles * consolidate dupe * import
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 4, 2019
…apache#7743) * allow quantiles merge aggregator to also accept doubles * consolidate dupe * import
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 26, 2019
* allow quantiles merge aggregator to also accept doubles * consolidate dupe * import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7660.
This PR just does the quicker fix, modifying the merge aggregator to allow it to operate on either
DoubleSketchselectors orDoubleselectors.The added test triggers a failure of the form:
without the modification of this patch.
While investigating this issue, I have been reviewing many of the complex value aggregators, which are not incredibly consistent with each other in terms of usage/construction, but all have very similar needs: being able to build complex values, and being able to merge complex values. Refactoring to try to find a common pattern feels out of scope of fixing this issue though, so I will be hopefully revisiting this in a follow-up proposal or PR.