SeekableStreamIndexTaskRunner: Lazy init of runner.#7729
Merged
fjy merged 1 commit intoapache:masterfrom May 23, 2019
Merged
Conversation
The main motivation is that this fixes apache#7724, by making it so the overlord doesn't try to create a task runner and parser when all it really wants to do is create a task object and serialize it.
himanshug
reviewed
May 22, 2019
| runner = createTaskRunner(); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
and here I thought that with all java8+ fanciness we would have a method in AtomicReference<T>.getOrCreate(Supplier<T>) but it seems this is still the way for lazy singleton.
Member
There was a problem hiding this comment.
guava has Suppliers.memoize that does this, we use it in a couple of places already
Contributor
There was a problem hiding this comment.
that sounds nice, now I remember seeing that :)
himanshug
approved these changes
May 22, 2019
Contributor
|
To me, this bug doesn't look critical enough to backport to 0.15.0. |
clintropolis
pushed a commit
to implydata/druid-public
that referenced
this pull request
May 24, 2019
The main motivation is that this fixes apache#7724, by making it so the overlord doesn't try to create a task runner and parser when all it really wants to do is create a task object and serialize it.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 3, 2019
The main motivation is that this fixes apache#7724, by making it so the overlord doesn't try to create a task runner and parser when all it really wants to do is create a task object and serialize it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation is that this fixes #7724, by making it so the overlord
doesn't try to create a task runner and parser when all it really wants to
do is create a task object and serialize it.