Merged
Conversation
gianm
approved these changes
May 23, 2019
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
The patch LGTM and I think it's been long enough that it makes sense to remove the old code. Could you please write up a draft of what should go into the release notes? Something about what to do if you're updating from a version before 0.12. Maybe you need to shut down your kafka supervisors first.
Contributor
Author
|
@gianm thanks for reminding me. I think I have to do some tests before adding the draft for release notes. I'm especially not sure about what happens if a task which was running with an old version is restored as a new version. I think it should just work as expected with the new version, but will try to make sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka indexing service supports Incremental handoff since 0.12.0 (#4815) and LegacyKafkaIndexTaskRunner was deprecated in 0.13.0.
After this PR, rolling update from a version < 0.12.0 is not supported.