Remove explicit snappy-java dependency#7811
Closed
Fokko wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
Any thoughts on this? |
Contributor
|
#8230 also removes the explicit snappy-java dependency |
Contributor
|
#8230 was merged and removed the explicit snappy-java dependency: https://github.com/apache/incubator-druid/pull/8230/files#diff-9876210e3556d07807fe3dbd7a8c3460L99 |
Contributor
Author
|
Awesome @ccaominh, thanks for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would remove the
snappy-javadependency from the Parquet subproject. This dependency is only required if you're using snappy compression, which is just one of the compressions for Parquet.Besides that, nothing will change because the Parquet plugin requires the Avro plugin, transitively pulls in the library:
However, explicitly adding this to the pom is not correct in my opinion.