Skip to content

Remove explicit snappy-java dependency#7811

Closed
Fokko wants to merge 1 commit intoapache:masterfrom
Fokko:fd-remove-snappy
Closed

Remove explicit snappy-java dependency#7811
Fokko wants to merge 1 commit intoapache:masterfrom
Fokko:fd-remove-snappy

Conversation

@Fokko
Copy link
Copy Markdown
Contributor

@Fokko Fokko commented May 31, 2019

I would remove the snappy-java dependency from the Parquet subproject. This dependency is only required if you're using snappy compression, which is just one of the compressions for Parquet.

Besides that, nothing will change because the Parquet plugin requires the Avro plugin, transitively pulls in the library:

[INFO] --------< org.apache.druid.extensions:druid-parquet-extensions >--------
[INFO] Building druid-parquet-extensions 0.16.0-incubating-SNAPSHOT     [34/64]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ druid-parquet-extensions ---
[INFO] org.apache.druid.extensions:druid-parquet-extensions:jar:0.16.0-incubating-SNAPSHOT
[INFO] +- org.apache.druid.extensions:druid-avro-extensions:jar:0.16.0-incubating-SNAPSHOT:provided
[INFO] |  +- org.apache.avro:avro:jar:1.8.2:provided
[INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.7:provided
[INFO] |  |  \- org.xerial.snappy:snappy-java:jar:1.1.1.3:compile

However, explicitly adding this to the pom is not correct in my opinion.

@Fokko Fokko changed the title Remove explicit snappy-java Remove explicit snappy-java dependency May 31, 2019
@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Jun 19, 2019

Any thoughts on this?

@ccaominh
Copy link
Copy Markdown
Contributor

ccaominh commented Aug 9, 2019

#8230 also removes the explicit snappy-java dependency

@ccaominh
Copy link
Copy Markdown
Contributor

#8230 was merged and removed the explicit snappy-java dependency: https://github.com/apache/incubator-druid/pull/8230/files#diff-9876210e3556d07807fe3dbd7a8c3460L99

@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Sep 13, 2019

Awesome @ccaominh, thanks for the heads up!

@Fokko Fokko closed this Sep 13, 2019
@Fokko Fokko deleted the fd-remove-snappy branch September 13, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants