Rename io.druid to org.druid in tdigestsketch extension#7996
Merged
clintropolis merged 3 commits intoapache:masterfrom Jul 1, 2019
Merged
Rename io.druid to org.druid in tdigestsketch extension#7996clintropolis merged 3 commits intoapache:masterfrom
clintropolis merged 3 commits intoapache:masterfrom
Conversation
gianm
reviewed
Jun 29, 2019
added 2 commits
June 29, 2019 21:45
Signed-off-by: Khwunchai Jaengsawang <khwunchai.j@ku.th>
Contributor
|
Rename checks out 👍 |
fjy
reviewed
Jun 29, 2019
clintropolis
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason tdigestsketch extension is still using
io.druidname, probably a small miss from #7331 code review.This PR also fixes pom.xml file for missing an argument which will eventually fail the build pipeline.
This PR has:
For reviewers: the key changed/added classes in this PR are
MyFoo,OurBar, andTheirBaz.(Add this section in big PRs to ease navigation in them for reviewers.)