Conversation
|
@jihoonson do we need LICENSE or NOTICE changes here? |
|
@jihoonson I added a script and did a comprehensive update of licenses.yaml |
|
I also put all the web-console licenses at the bottom of the license.yaml file |
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
@vogievetsky thanks for updating licenses! I reviewed only the licenses.yaml file and license pointer files. There are some missing copyrights and I left comments about them.
Regarding the new script you added, would you please add some description on how to use it? I think it could be added to both the PR description and web-console/README.md.
| --- | ||
|
|
||
| name: react-router-dom | ||
| name: "@babel/polyfill" |
There was a problem hiding this comment.
If you think it's a good idea to keep web-console dependencies separately from the Java stuffs, then it would be nice to add a comment to start a new section like # Licenses for web console dependencies.
| --- | ||
|
|
||
| name: react | ||
| name: "@types/dom4" |
There was a problem hiding this comment.
Copyright is missing for this dependency. Its license says
Copyrights are respective of each contributor listed at the beginning of each definition file.
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
I guess the copyright holder would be Adi Dahiya and Gilad Gray based on https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/dom4/index.d.ts#L3?
| --- | ||
|
|
||
| name: resize-observer-polyfill | ||
| name: "asap" |
There was a problem hiding this comment.
Missing copyright: https://github.com/kriskowal/asap/blob/master/LICENSE.md
| --- | ||
|
|
||
| name: toggle-selection | ||
| name: "core-js" |
There was a problem hiding this comment.
Missing copyright: https://github.com/zloirock/core-js/blob/v2.6.9/LICENSE
| --- | ||
|
|
||
| name: tiny-warning | ||
| name: "core-js" |
There was a problem hiding this comment.
Missing copyright: https://github.com/zloirock/core-js/blob/v1.2.7/LICENSE
| --- | ||
|
|
||
| name: Reactive Streams | ||
| name: "react-table" |
There was a problem hiding this comment.
Missing copyright: https://github.com/tannerlinsley/react-table/blob/master/LICENSE
| copyright: Austin Appleby who has placed MurmurHash3 in the public domain (https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp) | ||
| source_paths: | ||
| - processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/Groupers.java | ||
| name: "react-transition-group" |
There was a problem hiding this comment.
Missing copyright: https://github.com/reactjs/react-transition-group/blob/master/LICENSE. I guess it could be React Community Forked from React (https://github.com/facebook/react) Copyright 2013-present, Facebook, Inc..
| --- | ||
|
|
||
| name: AOP Alliance | ||
| name: "react" |
There was a problem hiding this comment.
Missing copyright: https://github.com/facebook/react/blob/master/LICENSE
| --- | ||
|
|
||
| name: Hive storage API | ||
| name: "scheduler" |
There was a problem hiding this comment.
Missing copyright: https://github.com/facebook/react/blob/master/LICENSE
| --- | ||
|
|
||
| name: JOpt Simple | ||
| name: "whatwg-fetch" |
There was a problem hiding this comment.
Missing copyright: https://github.com/github/fetch/blob/master/LICENSE
|
@jihoonson I addressed your feedback above |
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
Thanks for the fix! The updated licenses look good to me.
* update web console deps * update license.yaml * add tiny-warning * do not sort all licenses * fix snapshots * add final licenses * explicit mode * webpack tweaks * remove apache 2s * fixed missing license * added comments in script * put in markers * simpler script generator * add copyrights * more log
5 participants
Updated everything to latest and tested it out.
react-testing-librarybecame@testing-library/react(see: https://github.com/testing-library/react-testing-library/releases)Also this PR fixes #8074