optimize single string dimension expression selector#8014
Merged
gianm merged 6 commits intoapache:masterfrom Jul 4, 2019
Merged
optimize single string dimension expression selector#8014gianm merged 6 commits intoapache:masterfrom
gianm merged 6 commits intoapache:masterfrom
Conversation
gianm
approved these changes
Jul 4, 2019
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 4, 2019
* optimize single string dimension expression selector * more javadoc * oops * fix * fix it * import
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes in #7588 made it so that
SingleStringInputDimensionSelectorwill never be used for multi-value string columns. The "null adjustment" check that was done to cause this dimension selector to null out multi-value string dimensions is no longer necessary, allowing the implementation to be simplified/optimizedThis PR has: