Merged
Conversation
Since the Cardinality aggregator has a "round" option to round off estimated values generated from the HyperLogLog algorithm, add the same "round" option to the DataSketches HLL Sketch module aggregators to be consistent.
Contributor
|
The similar patch for hyperUnique and cardinality aggregators is here: #4720 |
gianm
reviewed
Jul 4, 2019
Contributor
|
The test failure looks legitimate. It happened while running in standards-compliant null handling mode, which I suppose changed the results a bit (2 rows came back instead of 1). |
Contributor
|
By the way, the mode is controlled by a system property. You can set |
gianm
reviewed
Jul 5, 2019
Contributor
gianm
left a comment
There was a problem hiding this comment.
This LGTM after the adjustment to the tests to handle the other null handling mode.
gianm
approved these changes
Jul 5, 2019
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 5, 2019
* Add round support for DS-HLL Since the Cardinality aggregator has a "round" option to round off estimated values generated from the HyperLogLog algorithm, add the same "round" option to the DataSketches HLL Sketch module aggregators to be consistent. * Fix checkstyle errors * Change HllSketchSqlAggregator to do rounding * Fix test for standard-compliant null handling mode
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 9, 2019
* Add round support for DS-HLL Since the Cardinality aggregator has a "round" option to round off estimated values generated from the HyperLogLog algorithm, add the same "round" option to the DataSketches HLL Sketch module aggregators to be consistent. * Fix checkstyle errors * Change HllSketchSqlAggregator to do rounding * Fix test for standard-compliant null handling mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the Cardinality aggregator has a "round" option to round off estimated
values generated from the HyperLogLog algorithm, add the same "round" option to
the DataSketches HLL Sketch module aggregators to be consistent.
This PR has:
For reviewers: the key changed/added classes in this PR are
HllSketchAggregatorFactory,HllSketchBuildAggregatorFactory,HllSketchMergeAggregatorFactory, andHllSketchAggregatorTest.