Skip to content

fix FileUtils performance regression due to FilterOutputStream #8024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjy merged 1 commit into from
Jul 4, 2019
Merged

fix FileUtils performance regression due to FilterOutputStream #8024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/src/main/java/org/apache/druid/java/util/common/FileUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,14 @@ private static OutputStream uncloseable(final OutputStream out)
{
return new FilterOutputStream(out)
{
// Default implementation of this method in FilterOutputStream converts single write operation to
// multiple write operations of 1 byte each, which is terribly inefficient.
@Override
public void write(byte b[], int off, int len) throws IOException
{
out.write(b, off, len);
}

@Override
public void close()
{
Expand Down