Fix license check in travis and make it optional#8049
Merged
gianm merged 8 commits intoapache:masterfrom Jul 10, 2019
Merged
Conversation
himanshug
reviewed
Jul 9, 2019
|
|
||
| mkdir -p target | ||
|
|
||
| mvn clean install -q -ff -DskipTests && docs/_bin/generate-license-dependency-reports.py . target --clean-maven-artifact-transfer && docs/_bin/generate-license.py licenses/APACHE2 licenses.yaml LICENSES.BINARY --dependency-reports target/license-reports |
Contributor
There was a problem hiding this comment.
since we are using "-Xmx3000m" in the next command anyway that means that much memory is available in this environment. so we can give this command same memory as well (not sure how much it needs but I guess , less than 3000m)
so basically move "MAVEN_OPTS='-Xmx3000m" in a separate line before both the commands.
Contributor
Author
There was a problem hiding this comment.
Thanks. Moved it to top.
Contributor
Author
|
This PR temporarily fixes the issue. I believe the better solution would be rewriting |
… into fix-travis-license-check
Merged
gianm
approved these changes
Jul 10, 2019
clintropolis
added
Area - Dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes the stalled travis. In this PR, I reduced the memory assigned for generating dependency reports. Also made this license check optional. Travis runs
build.shwhich runs two maven commands for license check and distribution build, respectively. To build distribution without license check, you can simply runmvn install -Pdist.