Merged
Conversation
jihoonson
approved these changes
Jul 12, 2019
Contributor
|
@Fokko thanks. Would you please update the PR description to say what's really fixed in this PR? |
Contributor
Author
|
@jihoonson Sure, I've added some lines. |
Contributor
Author
|
Thanks! |
Member
|
This PR might have caused Travis failures: #8135 |
clintropolis
added a commit
that referenced
this pull request
Jul 24, 2019
This reverts commit 04a180a.
clintropolis
added a commit
that referenced
this pull request
Jul 24, 2019
Fokko
added a commit
to Fokko/druid
that referenced
this pull request
Jul 30, 2019
Fokko
added a commit
to Fokko/druid
that referenced
this pull request
Jul 30, 2019
leventov
pushed a commit
that referenced
this pull request
Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Spotbugs
SS_SHOULD_BE_STATICrule. This class contains an instance final field that is initialized to a compile-time static value. Consider making the field static.Description
Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's
not necessary to repeat the description here, however, you may choose to keep one summary sentence.
Describe your patch: what did you change in code? How did you fix the problem?
If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For
example:
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
In each section, please describe design decisions made, including:
as when there are insufficient resources?
It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point
and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the
advantages of the chosen designs and names.
If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any
other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain
what have changed in your final design compared to your original proposal or the consensus version in the end of the
discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those
aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description.
Some of the aspects mentioned above may be omitted for simple and small changes.
This PR has:
Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the
items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary,
but it would be very helpful if you at least self-review the PR.
For reviewers: the key changed/added classes in this PR are
MyFoo,OurBar, andTheirBaz.(Add this section in big PRs to ease navigation in them for reviewers.)