Spotbugs: NP_NONNULL_PARAM_VIOLATION#8129
Merged
leventov merged 2 commits intoapache:masterfrom Aug 2, 2019
Merged
Conversation
Contributor
Author
|
Works on my CI: https://travis-ci.org/Fokko/druid/builds/562448511 |
Contributor
Author
|
Fixed conflicts |
leventov
requested changes
Jul 30, 2019
8 tasks
Fokko
force-pushed
the
NP_NONNULL_PARAM_VIOLATION
branch
from
b707bcd to
2efc47a
Compare
Contributor
Author
|
Rebased as well |
Fokko
force-pushed
the
NP_NONNULL_PARAM_VIOLATION
branch
from
690abc6 to
23df81d
Compare
Fokko
force-pushed
the
NP_NONNULL_PARAM_VIOLATION
branch
from
23df81d to
4a88f44
Compare
Contributor
Author
|
@leventov I've removed all the unrelated changes and rebased against latest master. Let me know what you think. Would be great to get this in so I can continue on fixing all the |
…NNULL_PARAM_VIOLATION
Contributor
Author
|
I guess a flakey test, it passed on my branch: https://travis-ci.org/Fokko/druid/builds/566424524 |
Member
|
@Fokko I just restarted the failed travis job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
NP_NONNULL_PARAM_VIOLATIONin Spotbugs