Skip to content

Add SuppressWarnings SS_SHOULD_BE_STATIC #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leventov merged 5 commits into from
Jul 31, 2019
Merged

Add SuppressWarnings SS_SHOULD_BE_STATIC #8138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
078b3fe
Add SuppressWarnings SS_SHOULD_BE_STATIC
Fokko Jul 23, 2019
4c287e1
Spotbugs: SS_SHOULD_BE_STATIC (#8073)
Fokko Jul 23, 2019
14a3df5
Fix the voilation
Fokko Jul 24, 2019
ded55cc
Make them non-final
Fokko Jul 29, 2019
cdb59ff
Remove @Nonnull
Fokko Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion codestyle/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
<Bug pattern="SF_SWITCH_FALLTHROUGH"/>
<Bug pattern="SF_SWITCH_NO_DEFAULT"/>
<Bug pattern="SR_NOT_CHECKED"/>
<Bug pattern="SS_SHOULD_BE_STATIC"/>
<Bug pattern="SWL_SLEEP_WITH_LOCK_HELD"/>
<Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH"/>
<Bug pattern="URF_UNREAD_FIELD"/>
Expand Down
15 changes: 6 additions & 9 deletions indexing-service/src/main/java/org/apache/druid/indexing/worker/config/WorkerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,32 +25,29 @@
import org.joda.time.Period;

import javax.validation.constraints.Min;
import javax.validation.constraints.NotNull;

/**
*/
public class WorkerConfig
{
@JsonProperty
@NotNull
private final String ip = DruidNode.getDefaultHost();
private String ip = DruidNode.getDefaultHost();

@JsonProperty
@NotNull
private final String version = "0";
private String version = "0";

@JsonProperty
@Min(1)
private final int capacity = Math.max(1, JvmUtils.getRuntimeInfo().getAvailableProcessors() - 1);
private int capacity = Math.max(1, JvmUtils.getRuntimeInfo().getAvailableProcessors() - 1);

@JsonProperty
private final long intermediaryPartitionDiscoveryPeriodSec = 60L;
private long intermediaryPartitionDiscoveryPeriodSec = 60L;

@JsonProperty
private final long intermediaryPartitionCleanupPeriodSec = 300L;
private long intermediaryPartitionCleanupPeriodSec = 300L;

@JsonProperty
private final Period intermediaryPartitionTimeout = new Period("P1D");
private Period intermediaryPartitionTimeout = new Period("P1D");

public String getIp()
{
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/apache/druid/server/security/AnonymousAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
@JsonTypeName("anonymous")
public class AnonymousAuthenticator implements Authenticator
{
private static final String DEFAULT_IDENTITY = "defaultUser";
private final AuthenticationResult anonymousResult;
private final String DEFAULT_IDENTITY = "defaultUser";

@JsonCreator
public AnonymousAuthenticator(
Expand Down