Skip to content

fix circular reference in moving average query #8192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clintropolis merged 1 commit into from
Jul 30, 2019
Merged

fix circular reference in moving average query #8192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ...query/src/main/java/org/apache/druid/query/movingaverage/MovingAverageQueryToolChest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
public class MovingAverageQueryToolChest extends QueryToolChest<Row, MovingAverageQuery>
{

private final QuerySegmentWalker walker;
private final Provider<QuerySegmentWalker> walkerProvider;
private final RequestLogger requestLogger;

private final MovingAverageQueryMetricsFactory movingAverageQueryMetricsFactory;
Expand All @@ -53,22 +53,21 @@ public class MovingAverageQueryToolChest extends QueryToolChest<Row, MovingAvera
* Construct a MovingAverageQueryToolChest for processing moving-average queries.
* MovingAverage queries are expected to be processed on broker nodes and never hit historical nodes.
*
* @param walker
* @param walkerProvider
* @param requestLogger
*/
@Inject
public MovingAverageQueryToolChest(Provider<QuerySegmentWalker> walker, RequestLogger requestLogger)
public MovingAverageQueryToolChest(Provider<QuerySegmentWalker> walkerProvider, RequestLogger requestLogger)
{

this.walker = walker.get();
this.walkerProvider = walkerProvider;
this.requestLogger = requestLogger;
this.movingAverageQueryMetricsFactory = DefaultMovingAverageQueryMetricsFactory.instance();
}

@Override
public QueryRunner<Row> mergeResults(QueryRunner<Row> runner)
{
return new MovingAverageQueryRunner(walker, requestLogger);
return new MovingAverageQueryRunner(walkerProvider.get(), requestLogger);
}

@Override
Expand Down