Enable Spotbugs NP_NONNULL_RETURN_VIOLATION#8234
Merged
leventov merged 3 commits intoapache:masterfrom Aug 20, 2019
Merged
Conversation
Fokko
force-pushed
the
NP_NONNULL_RETURN_VIOLATION
branch
from
10e7d4b to
35b0213
Compare
Contributor
Author
|
Rebased onto master |
…NNULL_RETURN_VIOLATION
Contributor
Author
|
Rebased onto master |
…NNULL_RETURN_VIOLATION
Contributor
Author
|
@leventov Can we move this forward? |
leventov
approved these changes
Aug 20, 2019
Member
|
@Fokko in general, please try to write to dev mailing list to draw attention of committers to the problem. |
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Aug 20, 2019
gianm
added a commit
that referenced
this pull request
Aug 21, 2019
* Docusaurus build framework + ingestion doc refresh. * stick to npm instead of yarn * fix typos * restore some _bin * Adjustments. * detect and fix redirect anchors * update anchor lint * Web-console: remove specific column filters (#8343) * add clear filter * update tool kit * remove usless check * auto run * add % * Fix resource leak (#8337) * Fix resource leak * Patch comments * Enable Spotbugs NP_NONNULL_RETURN_VIOLATION (#8234) * Fixes from PR review. * Fix more anchors. * Preamble nix. * Fix more anchors, headers * clean up placeholder page * add to website lint to travis config * better broken link checking * travis fix * Fixed more broken links * better redirects * unfancy catch * fix LGTM error * link fixes * fix md issues * Addl fixes
Contributor
Author
|
@leventov I will, thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Spotbugs
NP_NONNULL_RETURN_VIOLATIONrule. This checks of functions possibly return anullvalue but don't have the correct annotation.This PR has: