exclude kerberos extension dependencies that are already included in druid core libraries#8310
Merged
jon-wei merged 5 commits intoapache:masterfrom Aug 16, 2019
Merged
Conversation
This was referenced Aug 15, 2019
asdf2014
approved these changes
Aug 15, 2019
Member
Author
|
Oops, looks like |
Member
Author
jon-wei
approved these changes
Aug 16, 2019
Member
Author
|
Running some tests to make sure everything is still good after these changes |
Member
Author
|
Tested in a kerberized docker environment, http requests were functioning but, ran into an issue with it complaining about missing |
Member
Author
jihoonson
pushed a commit
to implydata/druid-public
that referenced
this pull request
Aug 23, 2019
…druid core libraries (apache#8310) * exclude kerberos extension dependencies that are already included in druid libs * missing net * exclude json-smart * eh might as well go aggro and remove all the ones it looks like we do not need * guess we actually need this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
While working on
NOTICEstuff for 0.16.0, noticed kerberos extension had a lot of dependencies that were already included inlib/folder of package, so I have excluded them from the kerberos extension pom.before:

after:

Looking at the actual classes the production dependencies use, this change appears safe to me, and in fact we could probably remove even more, but I haven't tested for reals so staying conservative-ish...