Skip to content

Use Codecov#8388

Merged
gianm merged 3 commits intoapache:masterfrom
ccaominh:codecov
Aug 28, 2019
Merged

Use Codecov#8388
gianm merged 3 commits intoapache:masterfrom
ccaominh:codecov

Conversation

@ccaominh
Copy link
Copy Markdown
Contributor

@ccaominh ccaominh commented Aug 24, 2019 •
edited
Loading

Description

Upload coverage reports to Codecov. For now, having Codecov comment on PRs or enforcing a minimum coverage threshold are both disabled until the Codecov coverage reports look reliable: https://codecov.io/gh/apache/incubator-druid

This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.

@asdf2014 asdf2014 added the Area - Dev For items related to the project itself, like dev docs and checklists, but not CI label Aug 26, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 26, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@95fa609). Click here to learn what that means.
The diff coverage is n/a.

@ccaominh ccaominh changed the title [WIP] Use Codecov Use Codecov Aug 27, 2019
@ccaominh
Copy link
Copy Markdown
Contributor Author

ccaominh commented Aug 27, 2019

The earlier comment from codecov-io is from when I was testing earlier with PR comments enabled, which is no longer enabled in the latest commit of this PR.

@ccaominh
Use Codecov
662dbb6 
Upload coverage reports to Codecov. For now, having Codecov comment on
PRs or enforcing a minimum coverage threshold are both disabled until
the Codecov coverage reports look reliable:
https://codecov.io/gh/apache/incubator-druid
@gianm
Copy link
Copy Markdown
Contributor

gianm commented Aug 27, 2019

Note to self and anyone else looking- this looks like the codecov report for this PR: https://codecov.io/gh/apache/incubator-druid/pull/8388. It's missing some views since there's no master report (which makes sense, sure).

gianm
gianm reviewed Aug 27, 2019
View reviewed changes
Comment thread .travis.yml Outdated
- free -m
after_success: &upload_java_unit_test_coverage
- ${MVN} -pl ${MAVEN_PROJECTS} jacoco:report
- travis_retry bash <(curl -s https://codecov.io/bash) -X gcov # retry in case of network error
Copy link
Copy Markdown
Contributor

@gianm gianm Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that bash here will run even if curl dies with an error, even in -e mode. I'd be more comfortable if this line was split up to prevent that from happening.

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Aug 27, 2019

LGTM other than the comment in #8388 (comment).

@ccaominh
Copy link
Copy Markdown
Contributor Author

ccaominh commented Aug 27, 2019

Codecov for the most recent commit in this PR: https://codecov.io/github/apache/incubator-druid/commit/0956b7b4500e79e2c270afafa7f093708db15932

gianm
gianm approved these changes Aug 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@gianm gianm merged commit 31e6280 into apache:master Aug 28, 2019
@ccaominh ccaominh deleted the codecov branch August 28, 2019 16:40
@jon-wei jon-wei added this to the 0.17.0 milestone Dec 17, 2019
@ccaominh ccaominh mentioned this pull request Jan 13, 2020
Closed
@cryptoe cryptoe mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gianm gianm gianm approved these changes

Assignees

No one assigned

Labels

Area - Dev For items related to the project itself, like dev docs and checklists, but not CI Area - Testing

Projects

None yet

Milestone

0.17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ccaominh @codecov-io @gianm @asdf2014 @jon-wei