Skip to content

make single/multi value string column handling official in aggregation #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himanshug merged 1 commit into from
Sep 3, 2019
Merged

make single/multi value string column handling official in aggregation #8428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@
* org.apache.druid.query.aggregation.cardinality.CardinalityAggregatorFactory}).
* Implementations of {@link AggregatorFactory} which need to Support Nullable Aggregations are encouraged
* to extend {@link NullableAggregatorFactory}.
*
* Implementations are also expected to correctly handle single/multi value string type columns as it makes sense
* for them e.g. doubleSum aggregator tries to parse the string value as double and assumes it to be zero if parsing
* fails.
* If it is a multi value column then each individual value should be taken into account for aggregation e.g. if a row
* had value ["1","1","1"] , doubleSum aggregation would take each of them and sum them to 3.
*/
@ExtensionPoint
public abstract class AggregatorFactory implements Cacheable
Expand Down