make it possible to not emit cache metrics and disable by default#8561
Merged
asdf2014 merged 1 commit intoapache:masterfrom Sep 24, 2019
Merged
make it possible to not emit cache metrics and disable by default#8561asdf2014 merged 1 commit intoapache:masterfrom
asdf2014 merged 1 commit intoapache:masterfrom
Conversation
Fokko
approved these changes
Sep 22, 2019
Contributor
Author
|
thanks all for reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8460
Description
Disables emitting of cache metrics by default and makes them optional. After this patch users would need to add
"org.apache.druid.client.cache.CacheMonitor"todruid.monitoring.monitorsproperty like others . It is already documented.Cache is disabled by default as
druid.realtime.cache.useCacheanddruid.realtime.cache.populateCacheare both set tofalseand so should be cache metrics.This PR has:
Release Notes
Users, who would like Druid to report cache metrics, should explicitly add
"org.apache.druid.client.cache.CacheMonitor"todruid.monitoring.monitorsproperty.