Skip to content

Web console: Widen Task ID and Created Time columns #8594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 1 commit into from
Sep 27, 2019
Merged

Web console: Widen Task ID and Created Time columns #8594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions web-console/src/views/task-view/__snapshots__/tasks-view.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ exports[`tasks view matches snapshot 1`] = `
"Header": "Task ID",
"accessor": "task_id",
"show": true,
"width": 300,
"width": 500,
},
Object {
"Aggregated": [Function],
Expand All @@ -551,6 +551,7 @@ exports[`tasks view matches snapshot 1`] = `
"Header": "Type",
"accessor": "type",
"show": true,
"width": 140,
},
Object {
"Cell": [Function],
Expand All @@ -570,7 +571,7 @@ exports[`tasks view matches snapshot 1`] = `
"Header": "Created time",
"accessor": "created_time",
"show": true,
"width": 120,
"width": 190,
},
Object {
"Cell": [Function],
Expand All @@ -589,6 +590,7 @@ exports[`tasks view matches snapshot 1`] = `
"accessor": "duration",
"filterable": false,
"show": true,
"width": 70,
},
Object {
"Aggregated": [Function],
Expand Down
6 changes: 4 additions & 2 deletions web-console/src/views/task-view/tasks-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ ORDER BY "rank" DESC, "created_time" DESC`;
{
Header: 'Task ID',
accessor: 'task_id',
width: 300,
width: 500,
Aggregated: () => '',
show: hiddenTaskColumns.exists('Task ID'),
},
Expand All @@ -755,6 +755,7 @@ ORDER BY "rank" DESC, "created_time" DESC`;
{
Header: 'Type',
accessor: 'type',
width: 140,
Cell: row => {
const value = row.value;
return (
Expand Down Expand Up @@ -799,7 +800,7 @@ ORDER BY "rank" DESC, "created_time" DESC`;
{
Header: 'Created time',
accessor: 'created_time',
width: 120,
width: 190,
Aggregated: () => '',
show: hiddenTaskColumns.exists('Created time'),
},
Expand Down Expand Up @@ -866,6 +867,7 @@ ORDER BY "rank" DESC, "created_time" DESC`;
{
Header: 'Duration',
accessor: 'duration',
width: 70,
filterable: false,
Cell: row => (row.value > 0 ? formatDuration(row.value) : ''),
Aggregated: () => '',
Expand Down