Fix for RoundRobinStorageLocationSelectorStrategy not to pick the same storage location over and again#8634
Merged
asdf2014 merged 2 commits intoapache:masterfrom Oct 12, 2019
Merged
Conversation
sashidhar
changed the title
Contributor
Author
|
@jihoonson please review. |
sashidhar
changed the title
jihoonson
approved these changes
Oct 11, 2019
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. @sashidhar thank you for the quick fix!
asdf2014
approved these changes
Oct 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8614.
Description
Fixes the issue with the possibility of
RoundRobinStorageLocationSelectorStrategypicking up same storage location over again.Fixed the bug by not sharing the iteration state returned by RoundRobinStorageLocationSelectorStrategy.getLocations() as per #8614 (comment).
This PR has:
Key changed/added classes in this PR
RoundRobinStorageLocationSelectorStrategyStorageLocationSelectorStrategyTest