OpenJDK historical segment hand-off fails with Illegal Field Name error

[tonyschwartz]

Description

While trying to use Druid (apache incubating) on OpenJDK (I have tried to run it with the latest 8 and 11 versions of OpenJDK), everything seems to work well, but when the segments go to be handed off to the "historical" segment manager (I'm not sure of the details of this), the app fails. All my segments then become "unavailable". coordinator-overlord.log shows this error:
2019-10-31T16:23:02,953 ERROR
[LeaderSelector[/druid/coordinator/_COORDINATOR]]
org.apache.curator.framework.listen.ListenerContainer - Listener
(org.apache.druid.curator.discovery.CuratorDruidLeaderSelector$1@1e7d3d87
)
threw an exception
java.lang.ClassFormatError: Illegal field name
"org.apache.druid.server.coordinator.DruidCoordinator$this" in class

a code change to: DruidCoordinator.java @line 690. the instance inner
class CoordinatorHistoricalManagerRunnable has a constructor that is
referencing DruidCoordinator.this prior to the super(...) constructor
call completing. This causes a failure. A work-around is to pass the
coordinator
instance to the constructor:
CoordinatorHistoricalManagerRunnable(final DruidCoordinator druidCoordinator, final int
startingLeaderCounter)
and then, reference druidCoordinator instead of DruidCoordinator.this throughout that
constructor.

---

Key changed/added classes in this PR

• DruidCoordinator.CoordinatorHistoricalManagerRunnable

[stale]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

[stale]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[stale]

This pull request/issue is no longer marked as stale.

[clintropolis]

@tonyschwartz apologies for missing this PR before the stale bot got to it. I had also previously encountered this issue, and re-opened this PR yesterday to confirm if the problem still exists in latest master and ask if you would be interested in fixing up the conflicts, however I believe the refactor in #7306 has also fixed what was causing the issue. Segments loaded correctly for me using Druid compiled with java 8 running on java 11, so I am going to close it again.