Web console: replace (and remove) old consoles

[vogievetsky]

Fixes #8150

This PR replaces and removes the legacy coordinator and overlord consoles and replaces them with the new console. The new console has been adapted to have smart capability detection with graceful fallback mode when running on services where not all the APIs are available.

Reasons for doing this:

• To provide a much better experience to new users with fewer components to understand. This is especially true with coordiantor.asOverlord mode being the new config default.
• The old consoles are not maintained and have a lot of "code rot" (the Coordiantor console has 10s of errors thrown in the JS console and the Overlord console uses a five year old version of jQuery with 23 LGTM alerts)
• The old consoles do not look good and are not visually consistent with each other.
• Fewer dependancies. The old consoles depend on some really old libraries.

I believe that the new console has full functional parity with what it is replacing but if I missed anything speak up and it will be addressed ASAP.

[clintropolis]

+1000

(not sure if my review counts since i made one of the commits 😜)

[lgtm-com]

This pull request fixes 28 alerts when merging 1f6a9e2 into 517c146 - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[fjy]

@vogievetsky I think this is failing web console UT

[lgtm-com]

This pull request fixes 28 alerts when merging 7eb8bb1 into 517c146 - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[clintropolis]

On the java side of things, I added a new WebConsoleJettyServerInitializer utility method that takes a ServletContextHandler and sets it up for serving the new web console, so that the same initialization code is now shared between router, coordinator, and overlord.

Additionally, there was a coordinator config that looked like it allowed specifying a custom location for the newer old coordinator console for development purposes, that has been removed.

[vogievetsky]

@clintropolis could you please add these redirects to Jetty:

/index.html -> /unified-console.html
/old-console/index.html -> /unified-console.html
/console.html -> /unified-console.html

[clintropolis]

@vogievetsky I have added the redirects from the old pages. While doing this I noticed that the 'coordinator mode' actually is not working if the overlord is down, presumably something related to the secret overlord proxy that it has if it is not running in the combined coordinator+overlord mode. Anyway, it makes the 'coordinator mode' totally non-functional, so I think we need to fix that.

[lgtm-com]

This pull request fixes 28 alerts when merging 21ff6e0 into c204d68 - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[vogievetsky]

Thanks @clintropolis fixed and pushed.

[lgtm-com]

This pull request fixes 28 alerts when merging 8ff3c9c into 6eacaf4 - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[clintropolis]

are there 2 versions of tslib? And does this version not have the NOTICE file?

[vogievetsky]

So that removed notice was removed because this is an auto generated block. It looks like you added the notice: key in https://github.com/apache/incubator-druid/pull/8306/files#diff-66ffa06e81466a207a1dad823ec2fe90R5049 but script/licenses which is what makes this block is not aware of it. What is the deal here? What does the notice: key represent and should script/licenses be updated to generate it?

[clintropolis]

What is the deal here? What does the notice: key represent and should script/licenses be updated to generate it?

The notice sections are manually maintained, and in fact must be, because we don't automatically include the entire notice, rather the part that is relevant to the code being used by Druid. These parts generate Druids own source and binary NOTICE files at distribution build time, so are really important to be correct and maintained.

I think we should probably modify the script to indicate to whoever runs it whenever a version of a dependency is updated that had a notice entry so that it can be manually updated. We went through all of the web dependencies as part of previous releases, but whenever we add new dependencies we should ensure that if they have a NOTICE file that the relevant contents make it into licenses.yaml. I don't think this script modification needs to be done as part of this PR, but we should at least preserve (and probably update) the notice entry for tslib.

[vogievetsky]

I edited script/licenses to make sure it preserves the notice and dedupes the libraries

[lgtm-com]

This pull request fixes 28 alerts when merging f98b954 into 75ea0d5 - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[jihoonson]

LGTM 👍

[lgtm-com]

This pull request fixes 28 alerts when merging 14f5e93 into df2f77c - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[lgtm-com]

This pull request fixes 28 alerts when merging 14f5e93 into df2f77c - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[lgtm-com]

This pull request fixes 28 alerts when merging e026739 into df2f77c - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[lgtm-com]

This pull request fixes 28 alerts when merging d22c178 into a066cc5 - view on LGTM.com

fixed alerts:

• 25 for Unused variable, import, function or class
• 1 for Useless assignment to local variable
• 1 for Comparison between inconvertible types
• 1 for Incomplete string escaping or encoding

[ccaominh]

LGTM 👍

[vogievetsky]

I think given the conversation on https://lists.apache.org/thread.html/d330190b2f4347843dbd82679ae29ded325219ec2ebbcedeffc69376@%3Cdev.druid.apache.org%3E this is good to go