Merged
Conversation
jon-wei
reviewed
Nov 16, 2019
Contributor
There was a problem hiding this comment.
I think this should just return nulls as is, any null->empty string conversion should have happened already at this point, so any nulls you see here should really be null
4e57bca to
dde7325
Compare
dde7325 to
0f13ecc
Compare
Contributor
|
I restarted the failed integration test. I'm not sure if it's transient or not, but we'll see. |
jon-wei
approved these changes
Nov 19, 2019
2 tasks
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Nov 26, 2019
* sampler returns nulls in CSV * fixed kafka sampler test * fix Kinesis test * sql compatibility fix * remove null to empty string conversion, use null * fix sql compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8845.
Description
When parsing a CSV in the sampler, if the whole column values are not provided but column header is provided, this column will be ignored.
Ideally we still want to return this column with values of null or "".
In this implementation it will return ""
This PR has: