Skip to content

refactor InputFormat and InputEntityReader implementations#8875

Merged
clintropolis merged 2 commits intoapache:masterfrom
clintropolis:refactor-input-format-and-reader
Nov 16, 2019
Merged

refactor InputFormat and InputEntityReader implementations#8875
clintropolis merged 2 commits intoapache:masterfrom
clintropolis:refactor-input-format-and-reader

Conversation

@clintropolis
Copy link
Copy Markdown
Member

This PR makes a minor refactor to #8823, modifying InputFormat.createReader to supply InputEntity and the temp dir to create the reader instead of supplying it to the read and sample methods of InputEntityReader, since a reader is intended to be tied to a single InputEntity.

Copy link
Copy Markdown
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense since the interface now says more clearly that InputEntityReader is stateful. +1 after CI.

@clintropolis
Copy link
Copy Markdown
Member Author

lgtm seems to be having issues running all PRs, the failure doesn't seem specific to this one:

[2019-11-16 00:05:58] [autobuild] [INFO] Running 'npm ci' in /opt/src/web-console
[2019-11-16 00:08:00] [autobuild] [ERROR] npm ERR! code E400
[2019-11-16 00:08:00] [autobuild] [ERROR] npm ERR! 400 Bad Request: domhandler@2.4.2

Going to merge this anyway, since I have two +1s and this is blocking something else I'm trying to work on.

@clintropolis clintropolis merged commit 7fa3182 into apache:master Nov 16, 2019
@clintropolis clintropolis deleted the refactor-input-format-and-reader branch November 16, 2019 01:08
@jon-wei jon-wei added this to the 0.17.0 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants