Overlord can support many autoscalers of different categories#8989
Closed
VladimirIordanov wants to merge 23 commits intoapache:masterfrom
Closed
Overlord can support many autoscalers of different categories#8989VladimirIordanov wants to merge 23 commits intoapache:masterfrom
VladimirIordanov wants to merge 23 commits intoapache:masterfrom
Conversation
added 18 commits
December 4, 2019 15:37
Initial implementation.
- Changed behavior config structure. - Small refactoring - Extended unit tests
- Extended unit tests
- Extended and refactored unit tests
- Extended and refactored unit tests
- Extended and refactored unit tests
- Fixed formatting
- Fixed unit tests
- Added "category" field into Autoscaler - Changed config format to support the "category" field - Fixed parameters of unit tests
- Fixed formatting
- Put category information into Autoscaler - Changed structure of behavior config - Changed CategoriedProvisioningStrategy accordingly - Fixed bug in PendingTaskBasedWorkerProvisioningStrategy - Extended unit tests - Code cleanup and refactoring
- Code refactoring
- Code refactoring
- Introduced new logic into the existing strategies
- Fixes and refactoring
- Added more test cases - Refactored unit tests
- Fixed code styles
VladimirIordanov
changed the title
VladimirIordanov
changed the title
Author
|
Hi @gianm. Any chance for this PR to be reviewed? |
added 5 commits
January 29, 2020 12:10
- Used Default Worker Category as a fallback for null worker categories
- Refactored legacy code to avoid NPE - Removed duplicates
- Added more debug info - Removed duplicated code
- Removed debug logging
VladimirIordanov
requested review from
himanshug
and removed request for
QiuMM
VladimirIordanov
changed the title
sascha-coenen
added a commit
to smaato/druid
that referenced
this pull request
Feb 11, 2020
Overlord can support many autoscalers of different categories apache#8989
Contributor
|
I will try and review #9350 over the weekend or next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8695.
Description
Added support of many autoscalers of different categories to serve tasks of according category.
This PR has:
Key changed/added classes in this PR
CategoriedWorkerBehaviorConfigPendingTaskBasedWorkerProvisioningStrategySimpleWorkerProvisioningStrategy