Using annotation to distinguish Hadoop Configuration in each module#9013
Merged
jihoonson merged 6 commits intoapache:masterfrom Dec 12, 2019
Merged
Using annotation to distinguish Hadoop Configuration in each module#9013jihoonson merged 6 commits intoapache:masterfrom
jihoonson merged 6 commits intoapache:masterfrom
Conversation
himanshug
approved these changes
Dec 11, 2019
Contributor
Author
|
@himanshug @clintropolis thank you for the review! |
Contributor
|
@jihoonson should this be backported to the 0.17 branch. |
Contributor
Author
|
@jnaous oh yeah, I will do it. |
jihoonson
added a commit
to jihoonson/druid
that referenced
this pull request
Dec 13, 2019
…pache#9013) * Multibinding for NodeRole * Fix endpoints * fix doc * fix test * Using annotation to distinguish Hadoop Configuration in each module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9004.
Description
This PR is based on #9005.
Each extension module needs to properly bind whatever it will use, but sometimes different modules need to bind the same class which will lead to the duplicate injection error. To avoid this problem, each module is supposed to bind different instances. This PR adds new annotations to bind different instances.
Also
ParquetReaderis changed to use the injected Configuration.This PR is tested with
This PR has: