Skip to content

[Backport] HRTR: make pending task execution handling to go through all tasks on not finding worker slots (#8697)#9022

Merged
jihoonson merged 1 commit intoapache:0.17.0-incubatingfrom
himanshug:backport_8697
Dec 13, 2019
Merged

[Backport] HRTR: make pending task execution handling to go through all tasks on not finding worker slots (#8697)#9022
jihoonson merged 1 commit intoapache:0.17.0-incubatingfrom
himanshug:backport_8697

Conversation

@himanshug
Copy link
Copy Markdown
Contributor

backports #8697

… not finding worker slots (apache#8697)

* HRTR: make pending task execution handling to go through all tasks on
not finding worker slots

* make HRTR methods package private that are meant to be used only in HttpRemoteTaskRunnerResource

* mark HttpRemoteTaskRunnerWorkItem.State global variables final

* hrtr: move immutableWorker NULL check outside of try-catch or finally block could have NPE

* add some explanatory comments

* add comment on explaining mechanics around hand off of pending tasks from submission to it getting picked up by a task execution thread

* fix spelling
@jihoonson jihoonson changed the title [Backport]HRTR: make pending task execution handling to go through all tasks on… [Backport] HRTR: make pending task execution handling to go through all tasks on not finding worker slots Dec 13, 2019
@jihoonson jihoonson changed the title [Backport] HRTR: make pending task execution handling to go through all tasks on not finding worker slots [Backport] HRTR: make pending task execution handling to go through all tasks on not finding worker slots (#8697) Dec 13, 2019
@jihoonson
Copy link
Copy Markdown
Contributor

Updated the title to help the missing backports script.

@himanshug
Copy link
Copy Markdown
Contributor Author

@jihoonson thanks, didn't know about that .. it would be great if that can be documented in CONTRIBUTING.md .

@jihoonson
Copy link
Copy Markdown
Contributor

Sounds great. It would also be great if we have a script for backporting PRs. I could be able to work on these sometime.. probably.

@himanshug
Copy link
Copy Markdown
Contributor Author

oh, from your message I got the [wrong] idea that there was probably some script that was doing something with backported PRs and that is why titles had to follow a specific format .

@jihoonson
Copy link
Copy Markdown
Contributor

Aha sorry for the confusion. You got the right idea. distribution/bin/find-missing-backports.py searches for all PRs which are in master but not in the given milestone branch. This works based on some pattern matching on the PR title.

Sounds great. It would also be great if we have a script for backporting PRs. I could be able to work on these sometime.. probably.

My comment was about a script backporting one PR in master into a branch. Gian shared his script before which is not completely configurable (for example, you have to fix the hard-corded user name in the script) and probably we can further generalize it.

@jihoonson jihoonson merged commit b8a7b99 into apache:0.17.0-incubating Dec 13, 2019
@himanshug
Copy link
Copy Markdown
Contributor Author

got it, thanks

@jon-wei jon-wei added this to the 0.17.0 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants