Skip to content

De-incubation cleanup in code, docs, packaging#9108

Merged
gianm merged 2 commits intoapache:masterfrom
jon-wei:deincubate
Jan 3, 2020
Merged

De-incubation cleanup in code, docs, packaging#9108
gianm merged 2 commits intoapache:masterfrom
jon-wei:deincubate

Conversation

@jon-wei
Copy link
Copy Markdown
Contributor

@jon-wei jon-wei commented Dec 29, 2019

This PR does some cleanup for the de-incubation:

  • Removes (incubating) text
  • Updates incubator-druid repo references to druid
  • Removes the incubation DISCLAIMER

Not addressed in this RR:

  • Version in pom.xml
  • Links to downloads such as https://www.apache.org/dyn/closer.cgi?path=/incubator/druid/{{DRUIDVERSION}}/apache-druid-{{DRUIDVERSION}}-bin.tar.gz
  • Updating ASF release process doc with the post-graduation process

@jon-wei jon-wei added the Apache Items related to being a part of the ASF label Dec 29, 2019
@jon-wei jon-wei added this to the 0.17.0 milestone Dec 29, 2019
2. From druid-website, checkout branch `asf-staging`.

3. From incubator-druid-website-src, run `./release.sh 0.16.0-incubating 0.16.0-incubating`, replacing `0.16.0-incubating` where the first argument is the release version and 2nd argument is commit-ish. This script will:
3. From druid-website-src, run `./release.sh 0.16.0-incubating 0.16.0-incubating`, replacing `0.16.0-incubating` where the first argument is the release version and 2nd argument is commit-ish. This script will:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these too?

### Cancelling a vote

If for any reason during the Druid PPMC or IPMC vote a blocking issue becomes apparent, a vote should be officially cancelled by sending an email with the following subject line: `[CANCEL][VOTE] Release Apache Druid (incubating) 0.15.1 [RC1]` and the reasons for the cancellation in the body.
If for any reason during the Druid PPMC or IPMC vote a blocking issue becomes apparent, a vote should be officially cancelled by sending an email with the following subject line: `[CANCEL][VOTE] Release Apache Druid 0.15.1 [RC1]` and the reasons for the cancellation in the body.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "IPMC" clause here should be removed, since Druid isn't part of the Incubator anymore.

Please also:

  • Remove the "IPMC vote" section and any other Incubator-related stuff in other sections. This includes replacing stuff like "Once a release candidate has passed the incubator PMC vote" with "Once a release candidate has passed the PMC vote". This will probably require re-reviewing the entire document.
  • Replace references to "Druid PPMC" with "Druid PMC". (PPMCs are for incubating projects.)
  • Remove requirement to notify general@incubator.apache.org of new releases.

Copy link
Copy Markdown
Contributor

@gianm gianm Dec 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I just noticed you marked this out of scope. Please ignore the above comment, but we do need to get it changed before we release 0.17.0.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, I was planning on updating that in a follow-on PR

- ZOO_MY_ID=1

coordinator:
image: apache/incubator-druid
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how our Docker builds get built. Does changing this require ASF Infra to do anything? If so, please add a sub-task for https://issues.apache.org/jira/browse/INFRA-19609.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/_bin/deploy-docs.sh Outdated
echo "Working directory [$tmp]"

git clone -q --depth 1 git@github.com:apache/incubator-druid-io.github.io.git "$target"
git clone -q --depth 1 git@github.com:apache/druid-io.github.io.git "$target"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither the old or the new repo is valid. Is this script still being used? If not, let's delete it.

Copy link
Copy Markdown
Contributor Author

@jon-wei jon-wei Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any references to it elsewhere in the repo, and there are newer scripts for docs build/publish now, so I deleted it

@gianm gianm merged commit aa53917 into apache:master Jan 3, 2020
jon-wei added a commit to jon-wei/druid that referenced this pull request Jan 3, 2020
* De-incubation cleanup in code, docs, packaging

* remove unused docs script
fjy pushed a commit that referenced this pull request Jan 4, 2020
* De-incubation cleanup in code, docs, packaging

* remove unused docs script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apache Items related to being a part of the ASF

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants